[PATCH] D30611: [x86] don't blindly transform SETB into SBB

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:34117
+    SDValue SBB = materializeSBB(Y.getNode(), Y.getOperand(1), DAG);
+    if (SBB.getValueSizeInBits() != VT.getSizeInBits())
+      SBB = DAG.getZExtOrTrunc(SBB, DL, VT);
----------------
ScalarSizeInBits - or is that being too pessimistic?


================
Comment at: test/CodeGen/X86/add-of-carry.ll:3
 ; RUN: llc < %s -mtriple=i686-unknown-unknown | FileCheck %s
 
 ; <rdar://problem/8449754>
----------------
The changes in this file don't look related to the patch.


================
Comment at: test/CodeGen/X86/peep-setb.ll:3
 ; RUN: llc -mtriple=x86_64-unknown-unknown < %s | FileCheck %s
 
 define i8 @test1(i8 %a, i8 %b) nounwind {
----------------
Again - not related to the patch


================
Comment at: test/CodeGen/X86/sse42-intrinsics-x86.ll:98
 
-define i32 @test_x86_sse42_pcmpestric128(<16 x i8> %a0, <16 x i8> %a2) {
+define i32 @test_x86_sse42_pcmpestric128(<16 x i8> %a0, <16 x i8> %a2) nounwind {
 ; SSE42-LABEL: test_x86_sse42_pcmpestric128:
----------------
The stack usage is unfortunate.....


https://reviews.llvm.org/D30611