[PATCH] D30437: [DAGCombiner] Do various combine on usubo.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 9 09:43:28 PST 2017


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM with one minor to check for vector types.



================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:2115
+  SDLoc DL(N);
+
+  // If the flag result is dead, turn this into an SUB.
----------------
deadalnix wrote:
> RKSimon wrote:
> > Can vectors ever use this? In which case we need to be careful of generating constants after legalization (see tryFoldToZero).
> I don't think so.
Please can you add an early out for vectors then, just in case.


https://reviews.llvm.org/D30437





More information about the llvm-commits mailing list