[PATCH] D28637: [PPC] Inline expansion of memcmp

Zaara Syeda via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 9 08:25:55 PST 2017


syzaara added inline comments.


================
Comment at: lib/CodeGen/CodeGenPrepare.cpp:2233
+    Builder.Insert(NewBr);
+    return;
+  }
----------------
efriedma wrote:
> Hmm... in isOnlyUsedInZeroEqualityComparison mode, it probably makes sense to perform more loads per block, to reduce the number of branches.
I'm not sure what you mean here. We have the branches for doing an early exit so we don't need to continue loading more bytes when we find a difference.


https://reviews.llvm.org/D28637





More information about the llvm-commits mailing list