[PATCH] D29489: Optimize SETCC + VSEL of incompatible or illegal types

[Jonas Paulsson via Phabricator via llvm-commits]

jonpa updated this revision to Diff 91167.
jonpa marked an inline comment as done.
jonpa added a comment.

Thanks for review - patch updated.

> Please clang-format the new code.

done.

> For the SystemZ tests, would it make sense to auto-generate the CHECK lines use update_llc_test_checks.py?

This results in

  KeyError: "Triple 's390x-linux-gnu' is not supported"

Is the script expected to support SystemZ?

In any case, I have generated the tests so that they first CHECK the expected sequence, and then CHECK-NOT what is supposed to not be there. I could change this to a sequence of CHECK-NEXTs, instead if that's better...


https://reviews.llvm.org/D29489

Files:
  lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp
  lib/CodeGen/SelectionDAG/LegalizeTypes.h
  lib/CodeGen/SelectionDAG/LegalizeTypesGeneric.cpp
  lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp
  test/CodeGen/ARM/vuzp.ll
  test/CodeGen/NVPTX/f16x2-instructions.ll
  test/CodeGen/SystemZ/vec-cmp-cmp-logic-select.ll
  test/CodeGen/SystemZ/vec-cmpsel.ll
  test/CodeGen/X86/2011-10-19-widen_vselect.ll
  test/CodeGen/X86/2011-10-21-widen-cmp.ll
  test/CodeGen/X86/psubus.ll
  test/CodeGen/X86/vselect-pcmp.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D29489.91167.patch
Type: text/x-patch
Size: 278055 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170309/8779d210/attachment-0001.bin>