[PATCH] D30755: [LV] Refactor cross-iteration phi's back-patching; NFC
Matthew Simpson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 9 05:50:09 PST 2017
mssimpso added a comment.
Hi Gil,
This looks good to me! I did have one minor suggestion to avoid some duplicated text in the comments. Also, you'll have to rebase to get the change from https://reviews.llvm.org/rL297302 (sorry about that).
================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:4003-4006
+ // At this point every instruction in the original loop is widened to a
+ // vector form. Now we need to fix the recurrences. These PHI nodes are
+ // currently empty because we did not want to introduce cycles.
+ // This is the second stage of vectorizing recurrences.
----------------
This paragraph seems to be mostly duplicating the previous. Can we reword it?
https://reviews.llvm.org/D30755
More information about the llvm-commits
mailing list