[llvm] r297377 - [SelectionDAG] Make SelectCode return void

Joey Gouly via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 9 05:38:08 PST 2017


Author: joey
Date: Thu Mar  9 07:38:06 2017
New Revision: 297377

URL: http://llvm.org/viewvc/llvm-project?rev=297377&view=rev
Log:
[SelectionDAG] Make SelectCode return void

SelectCode has been returning nullptr since 182dac0 ("SDAG: Make
SelectCodeCommon return void", 2016-05-10). Make SelectCode also
return void instead, as all callers have been updated.

Patch by Sven van Haastregt.

Review: https://reviews.llvm.org/D30497

Modified:
    llvm/trunk/utils/TableGen/DAGISelMatcherEmitter.cpp

Modified: llvm/trunk/utils/TableGen/DAGISelMatcherEmitter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/DAGISelMatcherEmitter.cpp?rev=297377&r1=297376&r2=297377&view=diff
==============================================================================
--- llvm/trunk/utils/TableGen/DAGISelMatcherEmitter.cpp (original)
+++ llvm/trunk/utils/TableGen/DAGISelMatcherEmitter.cpp Thu Mar  9 07:38:06 2017
@@ -955,7 +955,7 @@ void llvm::EmitMatcherTable(const Matche
   formatted_raw_ostream OS(O);
 
   OS << "// The main instruction selector code.\n";
-  OS << "SDNode *SelectCode(SDNode *N) {\n";
+  OS << "void SelectCode(SDNode *N) {\n";
 
   MatcherTableEmitter MatcherEmitter(CGP);
 
@@ -970,7 +970,6 @@ void llvm::EmitMatcherTable(const Matche
 
   OS << "  #undef TARGET_VAL\n";
   OS << "  SelectCodeCommon(N, MatcherTable,sizeof(MatcherTable));\n";
-  OS << "  return nullptr;\n";
   OS << "}\n";
 
   // Next up, emit the function for node and pattern predicates:




More information about the llvm-commits mailing list