[PATCH] D30668: Add llvm::sys::fs::real_path

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 9 01:40:34 PST 2017


labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

looks good to me, thank you for the patience. BTW I accidentally stumbled onto this https://docs.python.org/2/library/os.path.html#os.path.expanduser yesterday, so it looks like supporting tilde expressions on windows is not without precedent.

@mgorny: The immediate motivation is lowering similar code for this in lldb. I am not sure what are all the reasons lldb needs it in the first place, but I can totally believe that it is overusing this (OTOH, lldb only consumes paths, it does not produce them, so it's probably not that critical).  Still, maybe this is another reason to have ~ logic separate from real_path stuff -- then one could still support home directory expansion where it makes sense, without forcing full path resolution.


https://reviews.llvm.org/D30668





More information about the llvm-commits mailing list