[PATCH] D29854: WholeProgramDevirt: Implement importing for uniform ret val opt.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 8 15:30:52 PST 2017


pcc added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/WholeProgramDevirt.cpp:1078
+    auto &ResByArg = I->second;
+    // FIXME: We should figure out what to do about the "function name" argument
+    // to the apply* functions, as the function names are unavailable during the
----------------
tejohnson wrote:
> The function name should be available for each CallSite in each VirtualCallSite on the CSInfo.CallSites. But would the call sites be from more than one function?
These are not the names of the functions containing the call sites but rather the names of the virtual functions being called.

I think we'll probably want to somehow move these remarks into the exporting phase as well.


https://reviews.llvm.org/D29854





More information about the llvm-commits mailing list