[PATCH] D30485: Perform symbol binding for .symver versioned symbols

[Teresa Johnson via llvm-commits]

On Wed, Mar 8, 2017 at 12:37 PM, Rafael Avila de Espindola <
rafael.espindola at gmail.com> wrote:

> > +  /// Get the state recorded for the given symbol.
> > +  State symbolState(const MCSymbol *Sym) {
>
> Maybe name it getSymbolState?
>

Will do.
Thanks,
Teresa


>
> > +    // If we don't have a symbol attribute from assembly, then check if
> > +    // the aliasee was defined in the IR.
>
> It is a pity that we now need to look at both asm and IR, but I can't
> think of simple solution for it.
>
> This is fine with me, but please wait for pcc's review too.
>
> Cheers,
> Rafael
>



-- 
Teresa Johnson |  Software Engineer |  tejohnson at google.com |  408-460-2413
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170308/f20a0b06/attachment.html>