[PATCH] D30723: Add red zones to BumpPtrAllocator under ASan

[Pete Cooper via Phabricator via llvm-commits]

pete accepted this revision.
pete added a comment.
This revision is now accepted and ready to land.

Very cool.  Justin and I looked at ASan on BumpPtrAllocator a while ago and I think this would have been useful then too.  I think the reason you didn't find issues is that he fixed many of them already.

I think we could support SpecificBumpPtrAllocator but it would require walking the objects by 'sizeof(T) + RedZoneSize'.  RedZoneSize itself would also have to be set to make sure we continue to have appropriate alignment.  Not something you need to do now, but could be interesting in future.

So LGTM.  Thanks!


Repository:
  rL LLVM

https://reviews.llvm.org/D30723