[PATCH] D28965: [PGO] Value profile for size of memory intrinsic calls

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: lib/Transforms/Instrumentation/InstrProfiling.cpp:546
+      if (Kind == IPVK_MemOPSize)
+        TotalNS += I * (MemOPSizeRangeLast + 1);
+    }
----------------
xur wrote:
> davidxl wrote:
> > Larger range does not mean on average the number of values tracked will be proportionally larger. Perhaps using a different heuristic for allocation size? Besides, TotalNS tracks the number of value sites, overloading it for number of values does not make sense
> I removed this change. Now MemOPSize profile uses the same heuristic as indirect-call profiling.
With this default heuristics, do you see any dropped value profiling at runtime?


================
Comment at: tools/llvm-profdata/llvm-profdata.cpp:449
 
+typedef struct ValueSitesStats {
+  ValueSitesStats()
----------------
Can you split out this part as a refactoring patch?


https://reviews.llvm.org/D28965