[PATCH] D30731: [SLP] Visualize SLP trees with -view-slp-tree

[Adam Nemet via Phabricator via llvm-commits]

anemet added inline comments.


================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:1188
     }
+    E->UserTreeIndices.push_back(UserTreeIdx);
     DEBUG(dbgs() << "SLP: Perfect diamond merge at " << *VL[0] << ".\n");
----------------
mkuper wrote:
> I think this is where we want the FIXME. :-)
> Can you please add it -not for the entire thing, just that this here is a huge hack that makes the graph used for printing *more* precise than the graph actually used for vectorization...
OK, I added that.  It would be good explain the shuffle-order thing as well but I will leave that to you or Shahid.

Thanks for the review!


Repository:
  rL LLVM

https://reviews.llvm.org/D30731