[PATCH] D29670: [DebugInfo] Emit address space with DW_AT_address_class attribute for pointer and reference types

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

Two tiny nitpicks, but apart from that I'm happy.



================
Comment at: lib/AsmParser/LLParser.cpp:3930
 
+  Optional<unsigned> DWARFAddressSpace = None;
+  if (dwarfAddressSpace.Val != UINT32_MAX)
----------------
I think the = None is redundant.


================
Comment at: lib/Bitcode/Reader/MetadataLoader.cpp:1118
+    // that there is no DWARF address space associated with DIDerivedType.
+    Optional<unsigned> DWARFAddressSpace = None;
+    if (Record.size() > 12 && Record[12])
----------------
I think the = None is redundant


https://reviews.llvm.org/D29670