[PATCH] D30668: Add llvm::sys::fs::real_path

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/lib/Support/Windows/Path.inc:794
+  DWORD CountChars = ::GetFinalPathNameByHandleW(H, RealPathUTF16, MAX_PATH,
+                                                 FILE_NAME_NORMALIZED);
+  if (CountChars > 0 && CountChars < MAX_PATH) {
----------------
amccarth wrote:
> GetFinalPathNameByHandle is Vista+, no XP.  I assume that's OK.
I had a similar question earlier, but I noticed that we don't use the XP toolset in the MSVC build, so I'm guessing the LLVM tools are not supported on XP. Haven't investigated the official policy though.


https://reviews.llvm.org/D30668