[PATCH] D28759: [ExecutionDepsFix] Improve clearance calculation for loops

[Keno Fischer via Phabricator via llvm-commits]

loladiro added inline comments.


================
Comment at: llvm/trunk/lib/CodeGen/ExecutionDepsFix.cpp:837
+        processBasicBlock(Succ, false);
+        updateSuccessors(Succ, false);
+      }
----------------
mehdi_amini wrote:
> mehdi_amini wrote:
> > What is the limit on the depth of the stack?
> > We're seeing a crash because of stack explosion here, so I fear it can grow with the CFG (which wouldn't seem reasonable to me). Can you comment on this?
> Note: I haven't spent time figuring out what `ExeDepsFix` is doing, don't assume I have any context. The crash we're tracking is a ThinLTO bootstrap failure, we're still working on the exact reproducer.
Yes, I suppose it can grow with the number of nested loops. Must be quite a reproducer to cause this problem though. Unless of course there's something more fundamental wrong with the logic here (though for that I'd need the reproducer). In any case, it would be fine to change this to keep a working set in a SmallVector or something equivalent. 


Repository:
  rL LLVM

https://reviews.llvm.org/D28759