[PATCH] D30669: [NVPTX] Add an "image" attribute and simplify the NVPTX rdoimage, wroimage, and rdrwimage attributes.

[Justin Lebar via Phabricator via llvm-commits]

jlebar added a comment.

In https://reviews.llvm.org/D30669#695229, @arsenm wrote:

> What advantage over reserving an address space for images does this have? Now that we can have non-integral pointer types, why not just designate an address space for read/write images?


Hm, I guess that makes a lot of sense... I don't think it's legal to GEP, address space cast, or even do regular loads on these pointers, but whatever?

I'm a bit concerned that making this change will require changing all of the NVPTX texture and surface intrinsics, which is kind of a tall order and may have add-on consequences.  Is there a reasonable intermediate state?

Maybe we should just drop support for image args to kernels until we have a frontend which uses this.  It seems like otherwise, if we make a big change, we're somewhat likely to have to make another big change when we actually add front-end support.

WDYT?


https://reviews.llvm.org/D30669