[PATCH] D27050: [X86] Make library calls sensitive to regparm module flag (Fixes PR3997).

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

Minor comments, I like the approach, sorry for the delay



================
Comment at: include/llvm/Target/TargetLowering.h:167
 
+  class ArgListEntryBase {
+  public:
----------------
I think we can probably leave the `SDValue Node` field null when doing fast isel and get away without any subclassing. It simplifies the code that needs to take the address of all the arglistentries as well.


================
Comment at: include/llvm/Target/TargetLowering.h:2636-2638
+      SmallVector<ArgListEntryBase *, 8> ArgPtrs;
+      for (unsigned i = 0; i < Args.size(); ++i)
+        ArgPtrs.push_back(&(Args[i]));
----------------
Avoiding the subclassing would save this work


================
Comment at: lib/CodeGen/SelectionDAG/FastISel.cpp:879
+  SmallVector<TargetLoweringBase::ArgListEntryBase *, 8> ArgPtrs;
+  for (unsigned i = 0; i < Args.size(); ++i)
+    ArgPtrs.push_back(&(Args[i]));
----------------
ditto


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:2509
   case ISD::ADD:
+  case ISD::ADDC:
   case ISD::ADDE: {
----------------
Unrelated change?


https://reviews.llvm.org/D27050