[PATCH] D30651: [InlineCost, -Oz] Don't take into account the penalty of a fast call of frequently used functions

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 7 15:54:12 PST 2017


efriedma added inline comments.


================
Comment at: lib/Analysis/InlineCost.cpp:1216
+
+  return (Callee->getNumUses() >= static_cast<unsigned>(FrqFuncThreshold));
+}
----------------
This comparison seems backwards... generally, we assume non-local functions have many callers, and therefore treat them the same way as local functions with many callers.


https://reviews.llvm.org/D30651





More information about the llvm-commits mailing list