[PATCH] D30627: [ELF] Properly handle .eh_frame in linker scripts

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/SyntheticSections.cpp:507-508
   Sections.push_back(Sec);
+  std::move(Sec->DependentSections.begin(), Sec->DependentSections.end(),
+            std::back_inserter(DependentSections));
 
----------------
What is this for?


================
Comment at: ELF/Writer.cpp:227
+  if (!Config->Relocatable)
+    combineEHFrameSections<ELFT>();
+
----------------
EHFrame -> EhFrame since we have EhFrameSection.


================
Comment at: ELF/Writer.cpp:935-938
+  if (!Config->Relocatable) {
+    for (EhInputSection<ELFT> *ES : In<ELFT>::EhFrame->Sections)
+      Fn(*ES);
+  }
----------------
What is this?


Repository:
  rL LLVM

https://reviews.llvm.org/D30627