[PATCH] D30552: Fix regressions cased by D29862

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added a comment.

Hi,

Could you explain what was the problem and how this patch addresses it?

Thanks,
-Quentin



================
Comment at: lib/Transforms/Scalar/LoopStrengthReduce.cpp:1080
+    Special,  ///< A special case of basic, allowing -1 scales.
+    Address   ///< An address use; folding according to TargetLowering
     // TODO: Add a generic icmp too?
----------------
Unrelated change?


================
Comment at: lib/Transforms/Scalar/LoopStrengthReduce.cpp:4446
     }
-    LU.RecomputeRegs(LUIdx, RegUses);
     assert(LU.Formulae.size() == 1 && "Should be exactly 1 min regs formula");
     Formula &F = LU.Formulae[0];
----------------
Why don't we have to update Regs anymore?


Repository:
  rL LLVM

https://reviews.llvm.org/D30552