[PATCH] D30721: [GlobalISel] Add default action for G_FNEG

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 7 15:27:48 PST 2017


qcolombet accepted this revision.
qcolombet added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/CodeGen/GlobalISel/LegalizerHelper.cpp:556
+    default:
+      llvm_unreachable("unexpected floating-point type");
+    }
----------------
volkan wrote:
> qcolombet wrote:
> > Can't we simply reuse Ty?
> No, Ty is an instance of LLT.
Ah right, I forgot we had to go through LLVM IR to build floating-point constant.


https://reviews.llvm.org/D30721





More information about the llvm-commits mailing list