[PATCH] D28965: [PGO] Value profile for size of memory intrinsic calls

[David Li via Phabricator via llvm-commits]

davidxl added a comment.

The profile annotation part of another patch should be merged in here.



================
Comment at: include/llvm/Transforms/InstrProfiling.h:63
+  // The start value of precise value profile range for memory intrinsic sizes.
+  const int64_t DefaultMemOPSizeRangeStart = 0;
+  int64_t MemOPSizeRangeStart;
----------------
xur wrote:
> davidxl wrote:
> > should it be 1?
> there are calls to memory intrinsics with size 0.  There are quite many actually.
The value transformation patch does not seem to handle it .  Do you see cases where value 0 is a frequent value in hot stringop sites?


================
Comment at: lib/Transforms/Instrumentation/InstrProfiling.cpp:83
+    cl::desc("Set the range of size in memory intrinsic calls to be profiled "
+             "precisely, in a format of <start_val>:<end_val>"),
+    cl::init(""));
----------------
document the case when some value is missing in the option.


https://reviews.llvm.org/D28965