[llvm] r297209 - [GlobalISel] Don't translate intrinsics with metadata parameters.

Ahmed Bougacha via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 7 12:53:10 PST 2017


Author: ab
Date: Tue Mar  7 14:53:09 2017
New Revision: 297209

URL: http://llvm.org/viewvc/llvm-project?rev=297209&view=rev
Log:
[GlobalISel] Don't translate intrinsics with metadata parameters.

Some intrinsics take metadata parameters.  These all need custom
handling of some form, and cannot possibly be lowered generically to
G_INTRINSIC calls with vreg operands.
Reject them, instead of hitting an assert later in getOrCreateVReg.

Modified:
    llvm/trunk/lib/CodeGen/GlobalISel/IRTranslator.cpp
    llvm/trunk/test/CodeGen/AArch64/GlobalISel/arm64-fallback.ll

Modified: llvm/trunk/lib/CodeGen/GlobalISel/IRTranslator.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/GlobalISel/IRTranslator.cpp?rev=297209&r1=297208&r2=297209&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/GlobalISel/IRTranslator.cpp (original)
+++ llvm/trunk/lib/CodeGen/GlobalISel/IRTranslator.cpp Tue Mar  7 14:53:09 2017
@@ -745,6 +745,9 @@ bool IRTranslator::translateCall(const U
       MIRBuilder.buildIntrinsic(ID, Res, !CI.doesNotAccessMemory());
 
   for (auto &Arg : CI.arg_operands()) {
+    // Some intrinsics take metadata parameters. Reject them.
+    if (isa<MetadataAsValue>(Arg))
+      return false;
     if (ConstantInt *CI = dyn_cast<ConstantInt>(Arg))
       MIB.addImm(CI->getSExtValue());
     else

Modified: llvm/trunk/test/CodeGen/AArch64/GlobalISel/arm64-fallback.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/AArch64/GlobalISel/arm64-fallback.ll?rev=297209&r1=297208&r2=297209&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/AArch64/GlobalISel/arm64-fallback.ll (original)
+++ llvm/trunk/test/CodeGen/AArch64/GlobalISel/arm64-fallback.ll Tue Mar  7 14:53:09 2017
@@ -107,3 +107,14 @@ define i64 @atomic_ops(i64* %addr) {
   %res = load atomic i64, i64* %addr seq_cst, align 8
   ret i64 %res
 }
+
+; Make sure we don't mess up metadata arguments.
+declare void @llvm.write_register.i64(metadata, i64)
+
+; FALLBACK-WITH-REPORT-ERR: remark: <unknown>:0:0: unable to translate instruction: call: ' call void @llvm.write_register.i64(metadata !0, i64 0)' (in function: test_write_register_intrin)
+; FALLBACK-WITH-REPORT-ERR: warning: Instruction selection used fallback path for test_write_register_intrin
+; FALLBACK-WITH-REPORT-LABEL: test_write_register_intrin:
+define void @test_write_register_intrin() {
+  call void @llvm.write_register.i64(metadata !{!"sp"}, i64 0)
+  ret void
+}




More information about the llvm-commits mailing list