[PATCH] D30585: Fix test and add missing return for llvm-lto2 error case

[Teresa Johnson via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL297173: Fix test and add missing return for llvm-lto2 error case (authored by tejohnson).

Changed prior to commit:
  https://reviews.llvm.org/D30585?vs=90514&id=90881#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D30585

Files:
  llvm/trunk/test/tools/llvm-lto2/errors.ll
  llvm/trunk/tools/llvm-lto2/llvm-lto2.cpp


Index: llvm/trunk/test/tools/llvm-lto2/errors.ll
===================================================================
--- llvm/trunk/test/tools/llvm-lto2/errors.ll
+++ llvm/trunk/test/tools/llvm-lto2/errors.ll
@@ -10,5 +10,6 @@
 ; ERR4: invalid resolution: foo
 
 target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
 
 @foo = global i32 0
Index: llvm/trunk/tools/llvm-lto2/llvm-lto2.cpp
===================================================================
--- llvm/trunk/tools/llvm-lto2/llvm-lto2.cpp
+++ llvm/trunk/tools/llvm-lto2/llvm-lto2.cpp
@@ -157,9 +157,11 @@
         Res.FinalDefinitionInLinkageUnit = true;
       else if (C == 'x')
         Res.VisibleToRegularObj = true;
-      else
+      else {
         llvm::errs() << "invalid character " << C << " in resolution: " << R
                      << '\n';
+        return 1;
+      }
     }
     CommandLineResolutions[{FileName, SymbolName}].push_back(Res);
   }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D30585.90881.patch
Type: text/x-patch
Size: 977 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170307/bc17b612/attachment.bin>