[PATCH] D30115: [RFC] Add MachineInstr::MIFlag parameter to storeRegToStackSlot

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added a comment.

Hi Alex,

> I'm starting to wonder if I'd be better off making it so emitPrologue and emitEpilogue take an iterator pointing to after the callee-saved spill and before the callee-saved restores, particularly as it sounds like it's not particularly important to have these flags on callee saves/restores (ref), beyond this task of finding where to set the frame pointer.

On top of that I'd say this is not clear, at least to me, that we need to mark those as frame setup. I start to believe that we only need to mark only the operations that do stack/frame pointer adjustments.

Could you dig a little more before moving forward?

Cheers,
-Quentin


https://reviews.llvm.org/D30115