[PATCH] D30376: Playing with tokens OR breaking coroutines manually

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

In https://reviews.llvm.org/D30376#692486, @GorNishanov wrote:

> I agree that verifier could be more rigorous with checking that coroutine intrinsics are used properly, but, I would not want to change the tests ex0 - ex5.ll as you suggested.
>  ex?.ll tests are examples from the coroutine walkthrough in LLVM Coroutines doc and I would like to keep them in sync with the tutorial. They represent minimally useful, but still sensible coroutines.
>
> I would not object of adding new tests along the lines that your suggested (possibly with verifier changes to give better diagnostics) where assumptions about coroutine structure are violated.
>
> And I would like to add that I appreciate very much your interest in LLVM coroutines and proposing this patch.


Please do not get me wrong, I do not want to change the tests (as in the patch)! I merely want to point out that the verifier and the coverage are not that good and with the changed tests I wanted to show why.


https://reviews.llvm.org/D30376