[PATCH] D30638: [SLP] Fixed non-determenistic behavior in Loop Vectorizer.

Amjad Aboud via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 7 01:12:28 PST 2017


aaboud added a comment.

In https://reviews.llvm.org/D30638#693511, @mkuper wrote:

> Is there a reason not to make MemAccessInfoSet a SmallSetVector instead?


You are right, I needed to change "erase" to "remove" in order to work with SetVector, which I missed in my first try.
Notice that we will still need to iterate on the ordered set with a "while(!empty())" because we are removing entries from the Set while iterating on it.


https://reviews.llvm.org/D30638





More information about the llvm-commits mailing list