[PATCH] D30632: [LoopUnrolling] Fix loop size check for peeling
Sanjoy Das via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 6 22:15:13 PST 2017
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297122: [LoopUnrolling] Fix loop size check for peeling (authored by sanjoy).
Changed prior to commit:
https://reviews.llvm.org/D30632?vs=90787&id=90795#toc
Repository:
rL LLVM
https://reviews.llvm.org/D30632
Files:
llvm/trunk/lib/Transforms/Utils/LoopUnrollPeel.cpp
llvm/trunk/test/Transforms/LoopUnroll/peel-loop-not-forced.ll
Index: llvm/trunk/test/Transforms/LoopUnroll/peel-loop-not-forced.ll
===================================================================
--- llvm/trunk/test/Transforms/LoopUnroll/peel-loop-not-forced.ll
+++ llvm/trunk/test/Transforms/LoopUnroll/peel-loop-not-forced.ll
@@ -1,4 +1,4 @@
-; RUN: opt < %s -S -loop-unroll | FileCheck %s
+; RUN: opt < %s -S -loop-unroll -unroll-threshold=4 | FileCheck %s
define i32 @invariant_backedge_1(i32 %a, i32 %b) {
; CHECK-LABEL: @invariant_backedge_1
@@ -18,6 +18,34 @@
%incsum = add i32 %sum, %plus
%inc = add i32 %i, 1
%cmp = icmp slt i32 %i, 1000
+
+ br i1 %cmp, label %loop, label %exit
+
+exit:
+ ret i32 %sum
+}
+
+; Peeling should fail due to method size.
+define i32 @invariant_backedge_2(i32 %a, i32 %b) {
+; CHECK-LABEL: @invariant_backedge_2
+; CHECK-NOT: loop.peel:
+; CHECK: loop:
+; CHECK: %i = phi
+; CHECK: %sum = phi
+; CHECK: %plus = phi
+entry:
+ br label %loop
+
+loop:
+ %i = phi i32 [ 0, %entry ], [ %inc, %loop ]
+ %sum = phi i32 [ 0, %entry ], [ %incsum2, %loop ]
+ %plus = phi i32 [ %a, %entry ], [ %b, %loop ]
+
+ %incsum = add i32 %sum, %plus
+ %incsum2 = add i32 %incsum, %plus
+ %inc = add i32 %i, 1
+ %cmp = icmp slt i32 %i, 1000
+
br i1 %cmp, label %loop, label %exit
exit:
Index: llvm/trunk/lib/Transforms/Utils/LoopUnrollPeel.cpp
===================================================================
--- llvm/trunk/lib/Transforms/Utils/LoopUnrollPeel.cpp
+++ llvm/trunk/lib/Transforms/Utils/LoopUnrollPeel.cpp
@@ -75,7 +75,9 @@
// its only back edge. If there is such Phi, peeling 1 iteration from the
// loop is profitable, because starting from 2nd iteration we will have an
// invariant instead of this Phi.
- if (auto *BackEdge = L->getLoopLatch()) {
+ if (LoopSize <= UP.Threshold) {
+ BasicBlock *BackEdge = L->getLoopLatch();
+ assert(BackEdge && "Loop is not in simplified form?");
BasicBlock *Header = L->getHeader();
// Iterate over Phis to find one with invariant input on back edge.
bool FoundCandidate = false;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D30632.90795.patch
Type: text/x-patch
Size: 2086 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170307/c5c7b157/attachment.bin>
More information about the llvm-commits
mailing list