[PATCH] D30635: [XRay] [compiler-rt] Mark arg1 logging test as failing on !x86_64.

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 6 18:52:30 PST 2017


dberris added inline comments.


================
Comment at: test/xray/TestCases/Linux/arg1-logger.cc:12
 // At the time of writing, the ARM trampolines weren't written yet.
-// XFAIL: arm || aarch64
+// XFAIL: arm || aarch64 || mips || mips64 || powerpc64
 
----------------
pelikan wrote:
> sdardis wrote:
> > I believe this may require 'mipsel || mips64el' as well.
> Not according to grep -r.  I can see "powerpc64", "mips", "target-is-mips64" and "target-is-mips64el" and then triples.  In the LLVM repo, however, I can see "powerpc64-", "mips-" and "mips64-".  Fixed according to that.
Please look in compiler-rt, because the settings are different (these are deduced differently from the CMake set-up).


https://reviews.llvm.org/D30635





More information about the llvm-commits mailing list