[llvm] r297109 - remove Cmake option for LLVM_DISABLE_ABI_BREAKING_CHECKS_ENFORCING

Bob Wilson via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 6 16:51:08 PST 2017


Author: bwilson
Date: Mon Mar  6 18:51:07 2017
New Revision: 297109

URL: http://llvm.org/viewvc/llvm-project?rev=297109&view=rev
Log:
remove Cmake option for LLVM_DISABLE_ABI_BREAKING_CHECKS_ENFORCING

This is a follow-up to my change in r295090, which added support for
disabling these checks selectively based on setting the preprocessor
macro without relying on the Cmake setting. Swift has moved over to use
that approach, so we can clean up here and remove the Cmake setting.

https://reviews.llvm.org/D30578

Modified:
    llvm/trunk/CMakeLists.txt
    llvm/trunk/include/llvm/Config/abi-breaking.h.cmake

Modified: llvm/trunk/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/CMakeLists.txt?rev=297109&r1=297108&r2=297109&view=diff
==============================================================================
--- llvm/trunk/CMakeLists.txt (original)
+++ llvm/trunk/CMakeLists.txt Mon Mar  6 18:51:07 2017
@@ -396,9 +396,6 @@ option(LLVM_ENABLE_EXPENSIVE_CHECKS "Ena
 set(LLVM_ABI_BREAKING_CHECKS "WITH_ASSERTS" CACHE STRING
   "Enable abi-breaking checks.  Can be WITH_ASSERTS, FORCE_ON or FORCE_OFF.")
 
-option(LLVM_DISABLE_ABI_BREAKING_CHECKS_ENFORCING
-  "Disable abi-breaking checks mismatch detection at link-tim." OFF)
-
 option(LLVM_FORCE_USE_OLD_HOST_TOOLCHAIN
        "Set to ON to force using an old, unsupported host toolchain." OFF)
 

Modified: llvm/trunk/include/llvm/Config/abi-breaking.h.cmake
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Config/abi-breaking.h.cmake?rev=297109&r1=297108&r2=297109&view=diff
==============================================================================
--- llvm/trunk/include/llvm/Config/abi-breaking.h.cmake (original)
+++ llvm/trunk/include/llvm/Config/abi-breaking.h.cmake Mon Mar  6 18:51:07 2017
@@ -15,11 +15,8 @@
 /* Define to enable checks that alter the LLVM C++ ABI */
 #cmakedefine01 LLVM_ENABLE_ABI_BREAKING_CHECKS
 
-/* Define to disable the link-time checking of mismatch for
-   LLVM_ENABLE_ABI_BREAKING_CHECKS */
-#ifndef LLVM_DISABLE_ABI_BREAKING_CHECKS_ENFORCING
-#cmakedefine01 LLVM_DISABLE_ABI_BREAKING_CHECKS_ENFORCING
-#endif
+/* Allow selectively disabling link-time mismatch checking so that header-only
+   ADT content from LLVM can be used without linking libSupport. */
 #if !LLVM_DISABLE_ABI_BREAKING_CHECKS_ENFORCING
 
 // ABI_BREAKING_CHECKS protection: provides link-time failure when clients build




More information about the llvm-commits mailing list