[PATCH] D30364: AArch64 : Add FastCSEL feature.

Evandro Menezes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 6 16:00:04 PST 2017


evandro added a comment.

In https://reviews.llvm.org/D30364#693791, @flyingforyou wrote:

> @evandro 
>  This is code review about the case "Some targets using CSEL is more prefer than CSINV, CSINC.".
>
> And there were good discussions which way is better & correct for handling the issue. As you said, there is no specific target for this feature,now. 
>  I just wanted to get a confirm from other members, How to handle when we want to do this.


There may be more cases resulting in `CSET` that perhaps should remain `CSEL`.  In order to deal with all such situations, instead of just these matched by these `Pat`s, It seems to me that `TargetLowering` would be more flexible, whatever the reasons a target has for this.


https://reviews.llvm.org/D30364





More information about the llvm-commits mailing list