[PATCH] D26348: Allow convergent attribute for function arguments

[Matias Goldberg via Phabricator via llvm-commits]

dark_sylinc added a comment.

In https://reviews.llvm.org/D26348#693537, @mehdi_amini wrote:

> In https://reviews.llvm.org/D26348#693528, @hakzsam wrote:
>
> > This patch should also fix https://bugs.freedesktop.org/show_bug.cgi?id=99484
>
>
> Please read above my comment about this bug and how it can be fixed without changing LLVM.


While true, making texture calls have unknown behavior forces the compiler to prevent reordering at all... on an architecture that heavily relies on latency hiding (both horizontal i.e. wave occupancy and vertical i.e. instruction reordering).

Btw. I've been running Mesa radeonsi with this patch on top of LLVM 5.0 for my daily work and leisure time for almost a month now, and haven't encountered any issue.


https://reviews.llvm.org/D26348