[PATCH] D30525: [APInt] Add setLowBits/setHighBits methods to APInt.
Hans Wennborg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 6 09:58:16 PST 2017
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm
================
Comment at: include/llvm/ADT/APInt.h:226
+ // out-of-line slow case for setBits.
+ void setBitsSlowCase(unsigned loBit, unsigned hiBit);
----------------
Nit: the other methods use `///` to get doxygen comments.
================
Comment at: unittests/ADT/APIntTest.cpp:1664
+ EXPECT_EQ(16u, i32hi16.countPopulation());
+
+}
----------------
Nit: looks like an extra newline here.
https://reviews.llvm.org/D30525
More information about the llvm-commits
mailing list