[PATCH] D30566: [ELF] - Do not try to create .eh_frame_hdr for relocatable output.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 6 08:31:46 PST 2017
grimar added inline comments.
================
Comment at: ELF/Driver.cpp:230
+ if (Config->EhFrameHdr)
+ warn("--eh-frame-hdr is ignored when using -r");
+
----------------
ruiu wrote:
> Shouldn't we handle this as an error instead of a warning? All other incompatible combinations are handled as errors here.
According to comments compiler driver implicitly added --eh-frame-hdr, I afraid we probably may get many complains about link fails if this be a error().
Thats why I added it as a warning.
https://reviews.llvm.org/D30566
More information about the llvm-commits
mailing list