[PATCH] D30530: [ELF] - Implemented -z text/-znotext

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Driver.cpp:614
   Config->ZStackSize = getZOptionValue(Args, "stack-size", 0);
+  Config->ZText = getZOption(Args, "text", "notext");
   Config->ZWxneeded = hasZOption(Args, "wxneeded");
----------------
grimar wrote:
> ruiu wrote:
> > Do you actually need -z notext? You can just write `hasZOption(Args, "text")` like other options.
> The way other -z options implemented is incorrect I believe.
> There are few options thatmake a pairs, like -z text/notext, -z execstack/noexecstack, -z relro/norelro, -z combreloc/nocombreloc.
> Don't we want to be consistent and override previous -z options like we do for regular ones ?
Strictly speaking that is true, but for now focusing on -z text is better.


https://reviews.llvm.org/D30530