[PATCH] D30642: [ConstantFold] Fix defect in constant folding computation for GEP

Daniel Berlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 6 07:10:11 PST 2017


dberlin added a comment.

Is there a reason to split NewIdx and Idx at all?
I don't see it in this code and context.

That would solve your problem without introducing yet another array.
It also would be a step on fixing the N^2'dness of this function (since it restarts itself on the changed indices, which is silly)


https://reviews.llvm.org/D30642





More information about the llvm-commits mailing list