[PATCH] D30631: [BPI] Use metadata info before any other heuristics
Vedant Kumar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Mar 5 22:38:18 PST 2017
vsk added a comment.
I haven't worked on this area much, but this seems like a reasonable change.
The test case should be stronger because it would also pass if the change from https://reviews.llvm.org/D20363 were applied. Maybe you could use branch weight metadata which states that Pr[entry -> deopt] = 1, then check that we actually report that.
@skatkov you had a concern that this patch would cause PostDominatedByUnreachable to not be computed as often. What kinds of problems would this cause?
https://reviews.llvm.org/D30631
More information about the llvm-commits
mailing list