[PATCH] D29609: [dsymutil] Follow dependencies during ODR uniquing

[Frederic Riss via Phabricator via llvm-commits]

friss added a comment.

In https://reviews.llvm.org/D29609#690146, @alexshap wrote:

> 2. the same issue arises on more complicated cases - when the chain of references (via attributes) is longer then that in my simple test case.


Do you have an example of a more complicated testcase? I think only typedefs to structs or to pointers to structs can show this issue.

> However if you know how to fix this using a better approach - i am open to it and would really appreciate any suggestions /details here.
>  Having that said - with the current approach - the total performance has regressed smth around 1-2 % - that looks expected.

I prototyped an approach that I like better. I'm deciding during linking if a typedef is incomplete and then I just do not mark it as canonical if it's the case. I'm sending you the patch separately. Can you try to see if this works for you?


Repository:
  rL LLVM

https://reviews.llvm.org/D29609