[PATCH] D30612: [APInt] Add rvalue reference support to and, or, xor operations to allow their memory allocation to be reused when possible

[David Blaikie via llvm-commits]

On Sun, Mar 5, 2017 at 8:29 AM Craig Topper via Phabricator <
reviews at reviews.llvm.org> wrote:

> craig.topper added a comment.
>
> Removing the And, Or, Xor functions could be removed separately.
>
> The change to getBitsSet and intersects were necessary because of the
> operator functions being moved out of line. But they could be done as a
> pre-patch.
>

If you like, might make the patch quicker/easier to review.


>
> I hadn't looked at the move constructor. I was basing this on r276470 and
> assuming it was ok. Should I change it to use memcpy like the move
> assignment operator?
>

Even the assignment operator sort of seems not quite right - but maybe I'm
being overly cautious/incorrect here. (I'd expect it to need to memcpy the
union itself (which would need a name)).

Could also use the 'unified assignment operator' style - simplifying the
copy/move assignment operator to rely on the copy/move ctors.


>
>
> https://reviews.llvm.org/D30612
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170305/ef92a5ca/attachment.html>