[PATCH] D30437: [DAGCombiner] Do various combine on usubo.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:2115
+  SDLoc DL(N);
+
+  // If the flag result is dead, turn this into an SUB.
----------------
Can vectors ever use this? In which case we need to be careful of generating constants after legalization (see tryFoldToZero).


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:2119
+    return CombineTo(N, DAG.getNode(ISD::SUB, DL, VT, N0, N1),
+                     DAG.getUNDEF(CarryVT));
+
----------------
Is it possible to add an explicit test for this?


https://reviews.llvm.org/D30437