[PATCH] D30472: [DAGCombine] Simplify ISD::AND in GetDemandedBits.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 4 15:42:36 PST 2017


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM with one minor



================
Comment at: test/CodeGen/X86/illegal-bitfield-loadstore.ll:94
 ; ACHECK-NEXT:    retq
   %aa = load i56, i56* %a, align 1
   %b = or i56 %aa, 384
----------------
Please can you remove the old ACHECK lines? The update script won't touch comments it doesn't recognise, including unknown filecheck prefixes.


Repository:
  rL LLVM

https://reviews.llvm.org/D30472





More information about the llvm-commits mailing list