[PATCH] D30333: Split SimplifyCFG to run obscuring switch transforms only during last phase

[Joerg Sonnenberger via Phabricator via llvm-commits]

joerg added inline comments.


================
Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:377
   MPM.add(createAggressiveDCEPass());         // Delete dead instructions
-  MPM.add(createCFGSimplificationPass()); // Merge & remove BBs
+  MPM.add(createLateCFGSimplificationPass()); // Switches to lookup tables
   // Clean up after everything.
----------------
efriedma wrote:
> This is still interleaved with inlining; is that intentional?
Inlining is done in line 398 or 476, this function is called from 485. Is my understanding of the pass ordering wrong?
The intention is definitely to defer the switch transforms until all inlining is done.


https://reviews.llvm.org/D30333