[llvm] r296846 - [ProfileData] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

Eugene Zelenko via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 3 14:25:52 PST 2017


Hi, Vedant !

Mehdi and Zachary suggested awhile ago that such changes are fine with
post-commit reviews.

Could you please clarify what do you consider as "invasive"? Frankly,
I don't see anything "large" in them.

Eugene.

On Fri, Mar 3, 2017 at 2:17 PM, Vedant Kumar <vsk at apple.com> wrote:
> Eugene,
>
> Making this kind of large change without approval from anyone who works on the affected code is inappropriate. This pollutes the git history and creates churn I'd rather live without.
>
> If you must make these kinds of invasive changes, just ask for a review first.
>
> vedant
>
>> On Mar 2, 2017, at 5:07 PM, Eugene Zelenko via llvm-commits <llvm-commits at lists.llvm.org> wrote:
>>
>> Author: eugenezelenko
>> Date: Thu Mar  2 19:07:34 2017
>> New Revision: 296846
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=296846&view=rev
>> Log:
>> [ProfileData] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).
>>
>> Modified:
>>    llvm/trunk/include/llvm/ProfileData/Coverage/CoverageMapping.h
>>    llvm/trunk/include/llvm/ProfileData/Coverage/CoverageMappingReader.h
>>    llvm/trunk/include/llvm/ProfileData/Coverage/CoverageMappingWriter.h
>>    llvm/trunk/include/llvm/ProfileData/InstrProf.h
>>    llvm/trunk/include/llvm/ProfileData/InstrProfReader.h
>>    llvm/trunk/include/llvm/ProfileData/InstrProfWriter.h
>>    llvm/trunk/include/llvm/ProfileData/ProfileCommon.h
>>    llvm/trunk/include/llvm/ProfileData/SampleProf.h
>>    llvm/trunk/include/llvm/ProfileData/SampleProfReader.h
>>    llvm/trunk/include/llvm/ProfileData/SampleProfWriter.h
>>    llvm/trunk/lib/ProfileData/Coverage/CoverageMapping.cpp
>>    llvm/trunk/lib/ProfileData/Coverage/CoverageMappingReader.cpp
>>    llvm/trunk/lib/ProfileData/Coverage/CoverageMappingWriter.cpp
>>    llvm/trunk/lib/ProfileData/InstrProf.cpp
>>    llvm/trunk/lib/ProfileData/InstrProfReader.cpp
>>    llvm/trunk/lib/ProfileData/InstrProfWriter.cpp
>>    llvm/trunk/lib/ProfileData/SampleProf.cpp
>>    llvm/trunk/lib/ProfileData/SampleProfReader.cpp
>>    llvm/trunk/lib/ProfileData/SampleProfWriter.cpp


More information about the llvm-commits mailing list