[PATCH] D30161: [LoopUnrolling] Peel loops with invariant backedge Phi input

Michael Kuperstein via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 3 11:55:28 PST 2017


Hm, right, thanks Eli!

This ought to have the same threshold checks as the rest of loop unrolling
- since we're only unrolling one iteration here, I guess it should just be
"LoopSize <= UP.Threshold".

Michael

On Fri, Mar 3, 2017 at 11:48 AM, Eli Friedman via Phabricator <
reviews at reviews.llvm.org> wrote:

> efriedma added inline comments.
>
>
> ================
> Comment at: llvm/trunk/lib/Transforms/Utils/LoopUnrollPeel.cpp:95
> +      UP.PeelCount = 1;
> +      return;
> +    }
> ----------------
> Do we need to do some sort of threshold check here?  At first glance, it
> looks like this will peel a loop of any size.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D30161
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170303/8fb4afd4/attachment.html>


More information about the llvm-commits mailing list