[PATCH] D30313: [test-suite] Add regression test for indirect branch critical edge splitting

[Michael Kuperstein via llvm-commits]

r296896.

On Thu, Mar 2, 2017 at 10:42 AM, Matthias Braun via Phabricator <
reviews at reviews.llvm.org> wrote:

> MatzeB added a comment.
>
> In https://reviews.llvm.org/D30313#690815, @MatzeB wrote:
>
> > In https://reviews.llvm.org/D30313#690811, @MatzeB wrote:
> >
> > > Sorry to be this guy: This benchmark is running for too long! We
> should aim for 0.5-1s runtimes for our benchmarks and the `1000000` looks
> arbitrary to me. (This takes nearly 3x the time of salsa20, the next
> slowest benchmark in SingleSource/Benchmarks/Misc for me).
> >
> >
> > Just lowering is the way to go. Aiming for a specific wall time is
> contraproductive at least today, as we also have modes where we look at
> profile data and performance counters and want to compare them between runs.
> >
> > (Long term we should have something like googlebenchmark for our
> microbenchmarking here which would runt he function just often enough to
> get stable timing results. Maybe by tweaking it to run a fixed number of
> times for the cases with an external profiling tool.)
>
>
> For the record: This was in response to Michaels comment on llvm-commits
> which phabricator ignored...
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D30313
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170303/1fde801a/attachment.html>