[PATCH] D30525: [APInt] Add setLowBits/setHighBits methods to APInt.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 3 06:20:55 PST 2017


RKSimon added a comment.

In https://reviews.llvm.org/D30525#691195, @craig.topper wrote:

> I might even fix setBits to support loBit > hiBit like getBitsSet supports.


I'm not sure about this, which is why I didn't implement that way originally. Uses of getBitsSet are quite rare (and often could be replaced with simpler alternatives) - I'm still not sure if there are any uses of the 'wraparound' ability (or whether they are intentional....).


https://reviews.llvm.org/D30525





More information about the llvm-commits mailing list