[PATCH] D30566: [ELF] - Do not try to create .eh_frame_hdr for relocatable output.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 3 04:21:14 PST 2017


jhenderson added a comment.

Personally, I think that there should be a warning or error about incompatible command-line options in this case. A user has explicitly requested two different features that cannot be used together. We should tell them that -r wins out over --eh-frame-hdr.

I think it would make sense to put the test inside the same test as the normal .eh_frame_hdr test. That way we know for certain that an .eh_frame_hdr would definitely be created if -r was not specified, and that we aren't getting a spurious pass.


https://reviews.llvm.org/D30566





More information about the llvm-commits mailing list