[PATCH] D30495: [Polly][Cmake] Generate a PollyConfig.cmake

Philip Pfaffe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 3 02:48:14 PST 2017


philip.pfaffe added a comment.

In https://reviews.llvm.org/D30495#690821, @Meinersbur wrote:

> You seem to have decided against using it. Can you share why?


I didn't go with `export()` because it solves only half the problem. The exported targets are only valid for the build tree. The equivalent for the install tree would be `install(EXPORT)` together with the appropriate per-target install options. I don't think the second path is feasible for Polly, because it requires invasive changes to LLVM's cmake setup. Thus, I'd have to manually export the targets for the install tree anyways. I still could've used `export()` for the build tree, but I prefer the symmetry of my solution.

Updates wrt. to the inline comments coming soon.


Repository:
  rL LLVM

https://reviews.llvm.org/D30495





More information about the llvm-commits mailing list