[PATCH] D29703: [XRay] [compiler-rt] Allow logging the first argument of a function call.
Dean Michael Berris via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 3 00:38:59 PST 2017
dberris accepted this revision.
dberris added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: lib/xray/xray_fdr_logging.cc:497
case XRayEntryType::ENTRY:
+ case XRayEntryType::LOG_ARGS_ENTRY:
FuncRecord.RecordKind = uint8_t(FunctionRecord::RecordKinds::FunctionEnter);
----------------
Potentially provide a comment to suggest that we ought to support this explicitly later (something like `// FIXME: Handle actual argument logging later`).
https://reviews.llvm.org/D29703
More information about the llvm-commits
mailing list