[PATCH] D30524: Extract FindAvailablePtrLoadStore out of FindAvailableLoadedValue. NFCI

[Jun Bum Lim via Phabricator via llvm-commits]

junbuml added inline comments.


================
Comment at: lib/Analysis/Loads.cpp:321
 
+  return FindAvailablePtrLoadStore(
+      Load->getPointerOperand(), Load->getType(), Load->isAtomic(), ScanBB,
----------------
Do we really need to have this just to wrap  FindAvailablePtrLoadStore() in  FindAvailableLoadedValue? I guess it's also possible to change existing call sites of FindAvailableLoadedValue() just this like.


================
Comment at: lib/Analysis/Loads.cpp:326
+
+Value *llvm::FindAvailablePtrLoadStore(Value *Ptr, Type *AccessTy,
+                                       bool AtLeastAtomic, BasicBlock *ScanBB,
----------------
Don't you need to have if (!Load->isUnordered()) in FindAvailablePtrLoadStore as well?  


https://reviews.llvm.org/D30524